Modify to use the .pkl.gz extension
#31
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #30
Summary
This suggests using the
.pkl.gzextension rather than the present.pckl.gzipextension for dataset files.Motivation
There are several advantages to do so:
.gzis the standard extension for Gzip files (see https://www.gnu.org/software/gzip/manual/gzip.html and https://en.wikipedia.org/wiki/Gzip)..gzextension,df.to_pickleandpd.read_picklecan automatically decide to use Gzip for compression/expansion without explicitly specifying the compression argument..bz2.It would be also nicer to use
.pkl(or.pickle) rather thanpcklbecause.pklextension in their examples (seedf.to_pickleandpd.read_pickle)..pkl.gzcan be found on web in general than.pckl.gz. So people can more easily notice that this is in the pickle format.For already made
pckl.gzipfiles, we can simply rename them.Other changes
From an example in
docs/pacemaker/quickstart.md, I removed the protocol argument frompd.read_pickle(this argument exists fordf.to_picklebut not forpd.read_pickle).