Fix missing corner cases when computing sum-square updates -- #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovided by Mathieu Faverge to import fixes done in Chameleon
bosilca
reviewed
Apr 4, 2025
QingleiCao
approved these changes
Apr 10, 2025
| static inline void | ||
| sumsq_update( int nb, float *scale, float *sumsq, const float *value ) | ||
| { | ||
| float absval = fabs(*value); |
| } | ||
| #endif | ||
|
|
||
| #endif /* _sumsq_update_h_ */ |
There was a problem hiding this comment.
(Not for this PR) Why sumsq_update and sumsq_update_2?
Contributor
There was a problem hiding this comment.
used in src/zlange_frb_cyclic.jdf.
Contributor
There was a problem hiding this comment.
why not zsumsq_update with autoconversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is in the title, some corner cases were not handled correctly in norms and other places when computing the numerically stable sum-square updates.
This PR fixes issue #146
Patch provided by Mathieu Faverge to import fixes done in Chameleon.