Skip to content

AbstractDataGraph interface redesign #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jack-dunham wants to merge 12 commits into from
Closed

AbstractDataGraph interface redesign #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a06ca9c
Refactor interface to make more abstract; have `AbstractDataGraph` su…
jack-dunham Dec 3, 2025
c9eaeb0
Fix method overwrites
jack-dunham Dec 3, 2025
692b7b6
Remove `NamedGraphs` ext and move code to core module
jack-dunham Dec 3, 2025
accfdcb
Make `rename_vertices` generic by making use of `similar_graph` from …
jack-dunham Dec 4, 2025
b282355
Get `vertex_data_eltype` and `edge_data_eltype` directly from type pa…
jack-dunham Dec 4, 2025
8e85d6b
Add `Vertex/EdgeDataView` wrappers that lazily act like Dictionaries
jack-dunham Dec 4, 2025
e5e8860
The underlying graph type of `DataGraph` now must be a `AbstractNamed…
jack-dunham Dec 4, 2025
7c07b7f
Make `Base.reverse` method `AbstractDataGraph` more generic.
jack-dunham Dec 4, 2025
6b48268
Remove surplus code
jack-dunham Dec 4, 2025
4c0042d
DataViews now use a lazy filter to construct keys
jack-dunham Dec 11, 2025
fe3e986
Remove redundant methods
jack-dunham Dec 11, 2025
5981478
Improve and reorganise indexing interface
jack-dunham Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions examples/datagraph.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
using DataGraphs: DataGraph
using Graphs: Edge, grid, has_edge, has_vertex
using Graphs: has_edge, has_vertex
using NamedGraphs: NamedEdge
using NamedGraphs.NamedGraphGenerators: named_grid

g = grid((4,))
g = named_grid((4))
dg = DataGraph(g; vertex_data_eltype = String, edge_data_eltype = Symbol)
@show !isassigned(dg, Edge(1, 2))
@show !isassigned(dg, NamedEdge(1, 2))
@show !isassigned(dg, 1 => 2)
@show !isassigned(dg, Edge(1 => 2))
@show !isassigned(dg, NamedEdge(1 => 2))
@show !isassigned(dg, 1 => 3)
@show !isassigned(dg, 1)
@show !isassigned(dg, 2)
Expand Down Expand Up @@ -33,10 +35,10 @@ dg[4] = "V4"

dg[1 => 2] = :E12
dg[2 => 3] = :E23
dg[Edge(3, 4)] = :E34
dg[NamedEdge(3, 4)] = :E34
#@show isassigned(dg, (1, 2))
@show isassigned(dg, Edge(2, 3))
@show isassigned(dg, NamedEdge(2, 3))
@show isassigned(dg, 3 => 4)
@show dg[Edge(1, 2)] == :E12
@show dg[NamedEdge(1, 2)] == :E12
@show dg[2 => 3] == :E23
@show dg[3 => 4] == :E34
40 changes: 0 additions & 40 deletions ext/DataGraphsNamedGraphsExt/DataGraphsNamedGraphsExt.jl
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions src/DataGraphs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ module DataGraphs

include("utils.jl")
include("traits/isunderlyinggraph.jl")
include("dataview.jl")
include("abstractdatagraph.jl")
include("indexing.jl")
include("datagraph.jl")
# TODO: Turn into a weak dependency once `GraphsExtensions`
# is split off from `NamedGraphs`.
include("../ext/DataGraphsNamedGraphsExt/DataGraphsNamedGraphsExt.jl")

export AbstractDataGraph, DataGraph

Expand Down
Loading