Support php 8.4/8.5 #489
Open
Support php 8.4/8.5 #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
previously approved these changes
Dec 5, 2025
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
Code looks good, @Jan-Schuppik, please test the UI and approve this PR if everything works fine.
Contributor
There was a problem hiding this comment.
Github Actions are failing due to Code Sniffer. Please take a look at this.
Update: Code sniffer errors are fixed in #487.
sukhwinder33445
previously approved these changes
Dec 5, 2025
Jan-Schuppik
previously approved these changes
Dec 8, 2025
BastianLedererIcinga
dismissed stale reviews from Jan-Schuppik and sukhwinder33445
via
5eb10b8
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
3be25ae to
203cad9
Compare
…-8.4 compatibility
…efault value is deprecated in PHP8.4
…ince it will use the the values as array keys
Explictly set the required attribute of the uploaded_file element of BpUploadForm to true. previously the resulting-html element was not required and submitting the form caused null being passed. This is necessary because this class does not extend the Web\Form, and the Zend_Form does not mark the elment as required.
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
203cad9 to
ccebf08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes that had to be addressed
PHP 8.3 -> Php 8.4
Migration docs: https://www.php.net/manual/en/migration84
$escapeof fputcsv()must be set explicitlyresolves: #488