Skip to content

Conversation

@ManlyMarco
Copy link
Collaborator

No description provided.

@ManlyMarco ManlyMarco requested a review from Copilot October 18, 2025 18:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes directory creation by deferring the creation of the mods and temp directories until they are actually needed, rather than creating them during initialization. The property ModsPath has been renamed to ZipmodsPath to better reflect its purpose of storing zipmod files.

Key changes:

  • Renamed ModsPath to ZipmodsPath throughout the codebase for clarity
  • Changed directory initialization from Directory.CreateDirectory() to new DirectoryInfo() for mods and temp directories to avoid creating them unnecessarily
  • Added existence checks before accessing these directories to prevent errors when they don't exist yet

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/KKManager.Core/Functions/InstallDirectoryHelper.cs Renamed ModsPath to ZipmodsPath and changed initialization to use DirectoryInfo constructor instead of creating directories
src/KKManager.Core/Data/Zipmods/SideloaderModLoader.cs Updated reference from ModsPath to ZipmodsPath
src/KKManager.Core/Functions/ModInstaller.cs Updated reference from ModsPath to ZipmodsPath
src/KKManager.Updater/Windows/ModUpdateProgressDialog.cs Added existence checks before accessing PluginPath and ZipmodsPath directories
src/KKManager/Windows/MainWindow.cs Updated reference from ModsPath to ZipmodsPath

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ManlyMarco ManlyMarco merged commit fd4f3ad into master Oct 18, 2025
1 check failed
@ManlyMarco ManlyMarco deleted the a1 branch October 18, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants