-
Notifications
You must be signed in to change notification settings - Fork 74
Added checkbox-based selection system and bulk actions in CardWindow #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added checkbox-based selection system and bulk actions in CardWindow #229
Conversation
…older, select marked)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It will need some changes to be merged unfortunately.
First, it would be easier to handle if the features were separated into different PRs. A bit late for that now but something to keep in mind in the future.
The checkboxes are a good option to add but I think they should be treated identically to a normal selection when the checkbox mode is enabled. Having checkboxes act differently from normal selection is going to be confusing to users.
The new open in explorer button seems superfluous, I think the existing open in explorer button should be updated to open with cards selected if there are any selected in the list.
The removed comments I mentioned should be restored since they contained useful information. Please avoid changing things unrelated to the main goal of the PR in the future.
If you want to discuss this PR outside of github you can find me on Koikatsu Discord server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds optional checkbox-based selection, bulk actions, folder utilities, and duplicate detection/filtering to CardWindow to improve multi-card management.
- Checkbox selection with keyboard/mouse shortcuts and “Select marked” action
- Bulk move to folder and “Open selected in Explorer” for selected cards
- Duplicate filtering by multiple criteria with menu-driven toggles
Files not reviewed (1)
- src/KKManager/Windows/Content/CardWindow.Designer.cs: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Thanks, Marco! I originally made this as a small QoL tweak for myself, but I don’t mind sharing it if it helps others too, and honestly, if it gets implemented, I won’t have to rebuild it for myself every time there’s an update, lol. Since I’m not exactly a “real” programmer, I’ve been relying on AI to do the coding. So it’s mostly “vibe-coded,” and despite prompting it not to delete existing code or documentation, it sometimes changes or tries “optimizing” things anyway. Sorry if that makes it a bit messy, I'm trying to get better at this. If you’ve got any tips on how to better handle this, especially when it comes to using AI to code and not messing with previous code, I’d really appreciate it. Thanks! |
|
Being a "real" programmer isn't all that difficult really, it just means you're able to problem solve and look up useful information. You can even ask the LLM for explanations and pointers to further learning (of course don't trust it blindly but this is a decent use case). If you use Visual Studio then you should be able to use the "git changes" tab to selectively pick the changes you want and undo unnecessary changes. Most modern IDEs should have git integration like this, I suggest playing around with it a bit. My suggestion would be to try to split this PR into two - just the checkbox feature and just the additional filter. It should be a pretty good opportunity to learn some git basics. As I've mentioned before if you use discord you can reach out on there to ask for pointers. |
|
Thanks a lot for the help! I'll definitely look into it. I think I managed to make the changes you requested, I still need to look into how to split this into two separate PRs. Just bear with me, I might be a little busy for the moment. Should I make a new PR with only the checkboxes feature? I'll also include the fix you merged for the filename column in CardWindow. And until the checkbox one gets merged, I'll make another for the duplicate filter as well. |
Rolled back to only include checkbox changes, implemented changes, and removed filter feature
Rolled back to only include checkbox changes, implemented changes, and removed filter feature
|
I rolled back the changes to include only the checkbox feature and some of the requested adjustments, as well as other optimizations I updated in the 1st PR comment. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Please mark the PR as ready for review once it is ready for final review. |
Summary
This change introduces an optional checkbox-based selection system to make managing multiple cards more intuitive and flexible.
Changes
Why
Previously, selecting multiple cards using CTRL or SHIFT prevented the preview from updating, while clicking normally cleared all selections.
This made it cumbersome to review and manage multiple cards at once.
The new checkbox mode allows users to:
This makes managing large libraries smoother and more consistent with user expectations.