Skip to content

Conversation

@Timo713
Copy link

@Timo713 Timo713 commented Oct 19, 2025

Summary

This change introduces an optional checkbox-based selection system to make managing multiple cards more intuitive and flexible.

Changes

  • Added a “Use checkboxes” option under the View menu, allowing users to mark cards without losing the active preview.
  • Marked cards behave identically to normal selections, supporting bulk actions, like delete, move and drag & drop.
  • Added Spacebar, Numpad 0, and double-click shortcuts to toggle a card’s marked state quickly.
  • Marked cards are preserved between refreshes, unless they are deleted or moved.
  • Added “Unmark all” under the Tools menu to clear all marked cards in one click.
  • A “Move to folder…” option that opens with the current folder preselected.
  • “Open in Explorer” now supports selected or marked cards if there are any and opens their location and selects them.

Why

Previously, selecting multiple cards using CTRL or SHIFT prevented the preview from updating, while clicking normally cleared all selections.
This made it cumbersome to review and manage multiple cards at once.

The new checkbox mode allows users to:

  • Freely mark cards while keeping the preview active.
  • Perform normal bulk actions (delete, move, open folder) on marked cards.

This makes managing large libraries smoother and more consistent with user expectations.

@Timo713 Timo713 changed the title Added checkbox selection and multi-action support in CardWindow Added checkbox selection, bulk actions, and folder/duplicate utilities in CardWindow Oct 19, 2025
Copy link
Collaborator

@ManlyMarco ManlyMarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It will need some changes to be merged unfortunately.

First, it would be easier to handle if the features were separated into different PRs. A bit late for that now but something to keep in mind in the future.

The checkboxes are a good option to add but I think they should be treated identically to a normal selection when the checkbox mode is enabled. Having checkboxes act differently from normal selection is going to be confusing to users.

The new open in explorer button seems superfluous, I think the existing open in explorer button should be updated to open with cards selected if there are any selected in the list.

The removed comments I mentioned should be restored since they contained useful information. Please avoid changing things unrelated to the main goal of the PR in the future.

If you want to discuss this PR outside of github you can find me on Koikatsu Discord server.

@ManlyMarco ManlyMarco requested a review from Copilot October 19, 2025 20:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds optional checkbox-based selection, bulk actions, folder utilities, and duplicate detection/filtering to CardWindow to improve multi-card management.

  • Checkbox selection with keyboard/mouse shortcuts and “Select marked” action
  • Bulk move to folder and “Open selected in Explorer” for selected cards
  • Duplicate filtering by multiple criteria with menu-driven toggles
Files not reviewed (1)
  • src/KKManager/Windows/Content/CardWindow.Designer.cs: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Timo713
Copy link
Author

Timo713 commented Oct 19, 2025

Thanks, Marco! I originally made this as a small QoL tweak for myself, but I don’t mind sharing it if it helps others too, and honestly, if it gets implemented, I won’t have to rebuild it for myself every time there’s an update, lol.

Since I’m not exactly a “real” programmer, I’ve been relying on AI to do the coding. So it’s mostly “vibe-coded,” and despite prompting it not to delete existing code or documentation, it sometimes changes or tries “optimizing” things anyway.

Sorry if that makes it a bit messy, I'm trying to get better at this. If you’ve got any tips on how to better handle this, especially when it comes to using AI to code and not messing with previous code, I’d really appreciate it. Thanks!

@ManlyMarco
Copy link
Collaborator

Being a "real" programmer isn't all that difficult really, it just means you're able to problem solve and look up useful information. You can even ask the LLM for explanations and pointers to further learning (of course don't trust it blindly but this is a decent use case).

If you use Visual Studio then you should be able to use the "git changes" tab to selectively pick the changes you want and undo unnecessary changes. Most modern IDEs should have git integration like this, I suggest playing around with it a bit.

My suggestion would be to try to split this PR into two - just the checkbox feature and just the additional filter. It should be a pretty good opportunity to learn some git basics.

As I've mentioned before if you use discord you can reach out on there to ask for pointers.

@Timo713
Copy link
Author

Timo713 commented Oct 20, 2025

Thanks a lot for the help! I'll definitely look into it. I think I managed to make the changes you requested, I still need to look into how to split this into two separate PRs. Just bear with me, I might be a little busy for the moment.

Should I make a new PR with only the checkboxes feature? I'll also include the fix you merged for the filename column in CardWindow. And until the checkbox one gets merged, I'll make another for the duplicate filter as well.

@ManlyMarco ManlyMarco marked this pull request as draft October 21, 2025 22:57
Rolled back to only include checkbox changes, implemented changes, and removed filter feature
Rolled back to only include checkbox changes, implemented changes, and removed filter feature
@Timo713 Timo713 changed the title Added checkbox selection, bulk actions, and folder/duplicate utilities in CardWindow Added checkbox-based selection system and bulk actions in CardWindow Oct 25, 2025
@Timo713
Copy link
Author

Timo713 commented Oct 25, 2025

I rolled back the changes to include only the checkbox feature and some of the requested adjustments, as well as other optimizations I updated in the 1st PR comment.
If this gets merged, I’ll make a separate PR for the duplicate filter feature.
Hope it’s now working as intended, sorry for the messy changes history!
If you prefer I open a new PR for this instead, I can do that too.

ManlyMarco and others added 2 commits October 25, 2025 17:00
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ManlyMarco
Copy link
Collaborator

ManlyMarco commented Oct 25, 2025

Please mark the PR as ready for review once it is ready for final review.

@Timo713 Timo713 marked this pull request as ready for review October 25, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants