Cards - Take migration info into consideration; Add "Used plugins/zipmods" #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances card dependency tracking by adding support for zipmod GUID migration and introducing new properties to track all used plugins and zipmods (not just missing ones). The changes optimize the dependency checking logic by using HashSet-based lookups instead of repeated LINQ queries.
- Added support for zipmod GUID migration to correctly identify when old GUIDs should be considered "existing"
- Introduced
UsedPluginsandUsedZipmodsproperties to track all dependencies, not just missing ones - Optimized performance by pre-computing GUID HashSets instead of repeatedly iterating through collections
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CardLoader.cs | Enhanced zipmod migration support, optimized dependency checking with HashSet lookups, and populated new UsedPlugins/UsedZipmods properties |
| Card.cs | Added UsedZipmods and UsedPlugins properties to track all card dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves card loading speed.