feat: Add MIRI check to CI pipeline #104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please confirm you have read this contributor guide and followed the instructions. @dotandev |
There was a problem hiding this comment.
Pull request overview
This PR enhances the CI pipeline by adding MIRI (MIddleware Rust Interpreter) checks to detect undefined behavior in Rust code. MIRI is a powerful tool for finding memory safety issues and undefined behavior at runtime.
Changes:
- Added MIRI component installation to the GitHub Actions workflow
- Introduced a new "Miri Check" step that runs on Linux non-release builds
- Configured MIRI to test the workspace while excluding crates with LLVM FFI bindings (unsupported by MIRI) and IDE-related crates
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: dotdev. <jesuswrites20043@gmail.com>
Author
Contributor
|
@dotandev please address review comments |
Author
|
made a new PR #119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a step to the GitHub Actions CI pipeline to run MIRI (Undefined Behavior detector) on the codebase.
Changes
Modified
.github/workflows/reusable-build.yml:Added
rustup component add miri.Added
Miri Checkstep to the Linux build job.Configured to run cargo
miri test --workspacewith exclusions for crates that use LLVM bindings (FFI) which are currently unsupported by MIRI:inference-wasm-codegen(depends oninkwell)inference(depends onwasm-codegen)inference-cli(depends oninference)infs(app)inference-lsp(uses inkwell)inference-ide&inference-ide-db(excluded to reduce noise/compile time, focusing on core logic first)Verification
Verified
MIRIinstallation command locally.CI pipeline will now report any UB found in the core crates (AST, Type Checker, etc).
closes #17