Skip to content

[src] Add parameter validation and refine startVertexId handling #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RickYang1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[src] Add parameter validation and refine startVertexId handling #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Tearing/TearingScenarioEngine.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ void TearingScenarioEngine<DataTypes>::computeEndPoints(
Real norm_dir = dir.norm();

Pb = Pa + alpha/norm_dir * dir;
Pc = Pa - alpha /norm_dir * dir;
Pc = Pa;// -alpha / norm_dir * dir;
Copy link
Contributor

@epernod epernod Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pc = Pa;// -alpha / norm_dir * dir;

This should be kept because we want fracture in both direction from the fracture point (Pa).
And in case we are starting from a border, Pc will be out of the mesh.

}

template <class DataTypes>
Expand All @@ -129,6 +129,12 @@ void TearingScenarioEngine<DataTypes>::algoFracturePath()
helper::ReadAccessor< Data<VecCoord> > x(this->d_input_positions);
m_Pa = x[indexA];

if (indexA < 0 || indexA >= x.size())
{
msg_error() << "Invalid Input: startVertexId.";
return;
}

//Coord Pb, Pc;
computeEndPoints(m_Pa, dir, m_Pb, m_Pc);

Expand Down