-
Notifications
You must be signed in to change notification settings - Fork 18
feat: asynchronous query #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…epare query ticket and options
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 61.63% 61.92% +0.28%
==========================================
Files 33 33
Lines 2101 2135 +34
==========================================
+ Hits 1295 1322 +27
- Misses 806 813 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CHANGELOG.md
Outdated
|
|
||
| ### Features | ||
|
|
||
| 1. [123](https://github.com/InfluxCommunity/influxdb3-python/pull/123): Introduces `query_async` method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the CHANGELOG to outline the next steps for achieving full asyncio support—e.g., indicating if the next PR will add async write functionality or something else along those lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
bednar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Closes #
Proposed Changes
query_asyncmethod toquery_apiquery_apiquery_asyncmethod wrap call toFlightClient.doGetin current event loop retrieved fromasyncioquery_asyncmethod wrapFlightStreamReadertranslations in same event loopquery_apiInfluxDBClient3expose these changes with newquery_asyncmethodInfluxDBClient3tests/utilquery_api.__init__()improve merge of_flight_client_optionsso that some values do not get dropped or overwrittenChecklist