PG vector support #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns. New schema in Postgres is created for openmemory internal data.
maticdorian
reviewed
Jul 20, 2025
Collaborator
There was a problem hiding this comment.
How did you know which tables to create?
Collaborator
Author
There was a problem hiding this comment.
They are listed in the models.py file.
maticdorian
reviewed
Jul 20, 2025
maticdorian
reviewed
Jul 20, 2025
maticdorian
reviewed
Jul 20, 2025
openmemory/api/alembic/versions/7a2521026e06_create_openmemory_schema_and_tables.py
Outdated
Show resolved
Hide resolved
maticdorian
reviewed
Jul 20, 2025
maticdorian
reviewed
Jul 23, 2025
openmemory/api/app/models.py
Outdated
Comment on lines
173
to
174
| memory_id = Column(UUID, ForeignKey(f"{SCHEMA_NAME}.memories.id"), nullable=False, index=True) | ||
| changed_by = Column(UUID, ForeignKey(f"{SCHEMA_NAME}.users.id"), nullable=False, index=True) |
Collaborator
There was a problem hiding this comment.
I don't think you need to do this if you have the proper setup in env.py - you can just have "memories.id", for example
Collaborator
|
Should we use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.