Skip to content

Conversation

@ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Dec 11, 2025

This PR fixes the failing OS compiler workflow, which has been throwing a CMake error

OS compiler versioning output changed, so the Clang version is preceded by another string giving the date and specifying the compiler is the SYCL nightly compiler

This PR modifies dpctl CMake to check if the "Intel SYCL Compiler Nightly" string is in the version string. If so, the next member of the list, containing the Clang version, is used instead

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

coveralls commented Dec 11, 2025

Coverage Status

Changes unknown
when pulling 04a9f04 on fix-intel-sycl-compiler-cmake-os-ci
into ** on master**.

@ndgrigorian ndgrigorian force-pushed the fix-intel-sycl-compiler-cmake-os-ci branch 3 times, most recently from b4097f7 to 4be2052 Compare December 16, 2025 01:17
@ndgrigorian ndgrigorian force-pushed the fix-intel-sycl-compiler-cmake-os-ci branch from 4be2052 to bed074b Compare December 16, 2025 01:23
@ndgrigorian ndgrigorian marked this pull request as ready for review December 16, 2025 01:29
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_88 ran successfully.
Passed: 1115
Failed: 43
Skipped: 82

1 similar comment
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_88 ran successfully.
Passed: 1115
Failed: 43
Skipped: 82

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_88 ran successfully.
Passed: 1114
Failed: 44
Skipped: 82

antonwolfy
antonwolfy previously approved these changes Dec 17, 2025
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from me. LGTM!

now more robust, with an option for clang versioning (OS compiler) and DPC++ versioning
@ndgrigorian
Copy link
Collaborator Author

ndgrigorian commented Dec 17, 2025

@antonwolfy I've made a change to make this check more robust with regex, so each index is checked for either until a match is found, and that's used as the version. I added a commit to show the version, and as you can see, it matches what it was before. (last line in each screenshot)
DPC++:
Screenshot 2025-12-17 091039

OS compiler:
Screenshot 2025-12-17 091105

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_93 ran successfully.
Passed: 1116
Failed: 42
Skipped: 82

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_100 ran successfully.
Passed: 1115
Failed: 43
Skipped: 82

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_99 ran successfully.
Passed: 1115
Failed: 43
Skipped: 82

antonwolfy
antonwolfy previously approved these changes Dec 17, 2025
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor nit below, but overall LGTM!

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_100 ran successfully.
Passed: 1115
Failed: 43
Skipped: 82

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_101 ran successfully.
Passed: 1116
Failed: 42
Skipped: 82

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_100 ran successfully.
Passed: 1115
Failed: 43
Skipped: 82

@ndgrigorian ndgrigorian merged commit e041fca into master Dec 17, 2025
99 of 120 checks passed
@ndgrigorian ndgrigorian deleted the fix-intel-sycl-compiler-cmake-os-ci branch December 17, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants