-
Notifications
You must be signed in to change notification settings - Fork 32
Fix CMake error in OS compiler workflow #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Changes unknown |
b4097f7 to
4be2052
Compare
4be2052 to
bed074b
Compare
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_88 ran successfully. |
1 similar comment
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_88 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_88 ran successfully. |
antonwolfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more comments from me. LGTM!
now more robust, with an option for clang versioning (OS compiler) and DPC++ versioning
98d3194 to
3c380c9
Compare
|
@antonwolfy I've made a change to make this check more robust with regex, so each index is checked for either until a match is found, and that's used as the version. I added a commit to show the version, and as you can see, it matches what it was before. (last line in each screenshot) |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_93 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_100 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_99 ran successfully. |
antonwolfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a minor nit below, but overall LGTM!
da6a73c to
04a9f04
Compare
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_100 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_101 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_100 ran successfully. |


This PR fixes the failing OS compiler workflow, which has been throwing a CMake error
OS compiler versioning output changed, so the Clang version is preceded by another string giving the date and specifying the compiler is the SYCL nightly compiler
This PR modifies dpctl CMake to check if the "Intel SYCL Compiler Nightly" string is in the version string. If so, the next member of the list, containing the Clang version, is used instead