[Enhance] add training config printing to trainer #1385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyCle1024
reviewed
Dec 23, 2025
| ) | ||
| self.config = config | ||
| self._config = config | ||
| self._print_training_config() |
Collaborator
There was a problem hiding this comment.
If someone is using Trainer without from_config method, the config would not be printed. Is this the desired behavior?
Collaborator
Author
There was a problem hiding this comment.
What should be printed when Trainer is initialized without the from_config method? Otherwise, print the components of Trainer individually
HAOCHENYE
force-pushed
the
yehc/print-train-config
branch
from
3d19357 to
939cd3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.