Fix external function types #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
value as present. Replace unchecked access to _value with checked access for the various operators.
And define ptrdiff_t using decltype so it works for 32b and 64b arch.
This might be better with a high-level flag as well?
(Template wasn't being instantiated in my build environment, d'oh)
Support uint32, bool and float in function_base::push/pop Support int32 -> uint32 cast Allow bool output. Fix toStr(char*) for strings longer than 1. Add toStr(bool)
Added ExternalFunctionTypes.ink/cpp, which test a roundtrip of different types to the host. Updated CMakeLists.txt.
Allow type conversion on redefine if the casting matrix says the types have a common base. Allow bool->float conversion.
Support uint32, bool and float in function_base::push/pop Support int32 -> uint32 cast Allow bool output. Fix toStr(char*) for strings longer than 1. Add toStr(bool)
Added ExternalFunctionTypes.ink/cpp, which test a roundtrip of different types to the host. Updated CMakeLists.txt.
…vale/inkcpp into fix-external-function-types
Contributor
Author
|
This is a bit messy, there are only 3 relevant commits but I couldn't get it to rebase against master cleanly. |
Owner
|
Great find of cross-synergy. I did not think of this when implementing the new type system. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More type/casting fixes, this time for external function arguments and return values.