Add evaluation episodes in a new thread #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests for loggers, arch's, and use more verbose variable naming
Jacob/dev
Owner
Author
|
@BobMak How does this logic look for you? I'd still like to understand what the stop is doing, and whether the log interval is correct |
BobMak
reviewed
Jul 2, 2024
| train_fps = self.log_interval / train_time | ||
| self.log_history('time/train_fps', train_fps, self.learn_env_steps) | ||
| self.avg_eval_rwd = self.evaluate() | ||
| if self.use_threaded_eval: |
Collaborator
There was a problem hiding this comment.
looks like we are waiting for the finish of the old worker but not starting the new worker thread when self.use_threaded_eval is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs: