4주차 실습 Pull Request #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skdud0629
reviewed
Nov 10, 2024
skdud0629
left a comment
skdud0629
left a comment
There was a problem hiding this comment.
네이밍 컨벤션만 잘 지키시면 될 것 같습니다!
ui 구성 잘 하셨어요!😊
| <!-- EditText 색상 --> | ||
| <style name="EditTextStyle"> | ||
| <item name="android:backgroundTint">@color/light_edit_text_background</item> | ||
| <item name="android:textColorHint">@color/light_hint_text_color</item> |
There was a problem hiding this comment.
꼭 색깔만 정의할 수 있는 게 아니라 gravity나 textSize 등 다른 요소도 활용할 수 있습니다!
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="16dp" | ||
| android:text="로그인"/> |
| <style name="Theme.Assignment_week_02" parent="Base.Theme.Assignment_week_02" /> | ||
|
|
||
| <!-- TextView 색상 --> | ||
| <style name="TEXT"> |
There was a problem hiding this comment.
왜 얘만 이름이 대문자인거죵
어떤 view 에 활용되는 테마인지 명시하면 나중에 알아보기 편하겠죠?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
실습 과제 3 PR입니다.