14주차 과제 PR입니다. #11
Open
14주차 과제 PR입니다. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skdud0629
reviewed
Feb 21, 2025
| private lateinit var binding: ActivityMainBinding | ||
| private lateinit var wordAdapter: WordAdapter | ||
| private val viewModel: WordsViewModel by viewModels() | ||
| private val permission = Manifest.permission.READ_MEDIA_IMAGES |
There was a problem hiding this comment.
readMediaImagesPermission
더 직관적인 변수명을 사용하는 걸 권장합니당
| private val viewModel: AddEditWordViewModel by viewModels() | ||
| private var selectedImageUri: Uri? = null | ||
|
|
||
| private val imagePickerLauncher = registerForActivityResult(ActivityResultContracts.GetContent()) { uri -> |
There was a problem hiding this comment.
registerForActivityResult 선언은 oncreate에서 해주세요!
| private val _wordMeaning = MutableLiveData("") | ||
| val wordMeaning: LiveData<String> = _wordMeaning | ||
|
|
||
| private val _eventFlow = MutableSharedFlow<UiEvent>() |
| import androidx.lifecycle.ViewModel | ||
| import androidx.lifecycle.viewModelScope | ||
| import com.example.assignment.feature_word.domain.model.Word | ||
| import com.example.assignment.feature_word.domain.use_case.WordUseCases |
| ) | ||
| ) | ||
| _eventFlow.emit(UiEvent.SaveWord) | ||
| } catch (e: InvalidWordException) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
14주차 과제 PR입니다.