7주차 과제 PR입니다. #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skdud0629
reviewed
Dec 4, 2024
| private val onItemLongClick: (Int) -> Unit | ||
| ) : RecyclerView.Adapter<NameAdapter.ViewHolder>() { | ||
|
|
||
| class ViewHolder(view: View) : RecyclerView.ViewHolder(view) { |
There was a problem hiding this comment.
Suggested change
| class ViewHolder(view: View) : RecyclerView.ViewHolder(view) { | |
| inner class ViewHolder(view: View) : RecyclerView.ViewHolder(view) { |
|
|
||
| private fun setupAddButton() { | ||
| val nameEditText = findViewById<EditText>(R.id.editText) | ||
| findViewById<Button>(R.id.addButton).setOnClickListener { |
There was a problem hiding this comment.
EditText는 변수로 따로 선언해주시고 Button은 따로 선언 안해주셨네용
기능적으로 문제 있는 거는 아니지만 좀 더 가독성 있는 코드를 작성하기 위해..
|
|
||
| AlertDialog.Builder(this) | ||
| .setTitle("수정") | ||
| .setView(editText) |
There was a problem hiding this comment.
edittext가 들어간 커스텀 다이얼로그를 만들어보는 거는 어떨까용??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7주차 과제 PR입니다.