Skip to content

Conversation

@daudihusbands
Copy link

Hi James,
I found your directive very useful. Thank you for putting this together. I wanted to contribute a few minor additions.

  • Added a new parameter autoSignin to the directive that will force a signin for all routes/states.
  • Added support for navigation via states using ui-router (https://github.com/angular-ui/ui-router)

Regards,
Daudi

@daudihusbands
Copy link
Author

Sorry about that last commit. I opened the file in Visual Studio and voila.. auto format.

@JamesRandall
Copy link
Owner

They look like useful additions - thanks for the pull request!

Do you know what you changed in that last commit? I should be able to figure it out but don't want to miss anything!

In any case I'll try and get this merged this weekend - thank you!

@daudihusbands
Copy link
Author

The last commit is really about allowing the user to request user info after the 'oauth2:authSuccess' event has fired.

Added/modified lines:
line 336: userInfoUrl: '@'...
lines 413-420: if (scope.userInfoUrl && scope.userInfoUrl.length > 0) .....

@daudihusbands
Copy link
Author

BTW. Have you looked at these repositories written by @dominickbaier and @brockallen?https://github.com/IdentityModel/oidc-token-manager, https://github.com/IdentityModel/IdentityModel.OidcClient

I'm thinking about refactoring this into AngularJs. Your work here has inspired me in the right direction.

@JamesRandall
Copy link
Owner

Thanks for the help - I'll get that included, and thanks again for the pull request - really appreciated.

I'm a big fan of those guys work - it's superb stuff and I use IdentityServer extensively. If you're looking at doing work in this space there stuff, along with the surprisingly readable, OpenID Connect spec are excellent references.

@brockallen
Copy link

I'm happy to help on this front -- I have my own TODO item to wrap the oidc-client library into something usable by NG or NG2. Also, on a side note, I've been rewriting the oidc-client and token-manager libraries in es6. You can see the progress here: https://github.com/IdentityModel/oidc-client-js/tree/dev

@pinnprophead
Copy link

I would be willing to help. I wrote a wrapper Angular service to wrap oidc -- nothing great but its a start.

@brockallen
Copy link

@brockallen
Copy link

Also, just an update on the rewrite I'm doing... I'm about 95% done -- just a bit more then I will release the rewritten library. Any work on this front I'd encourage to be done on the rewritten oidc-client library.

@daudihusbands
Copy link
Author

This is very encouraging. I also started my efforts to port to NG. Shall we converge our efforts under a single umbrella? Maybe @brockallen work can be that starting point. Seems like he won't need us after all :)

@brockallen
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants