Skip to content

Conversation

@cmontecoding
Copy link
Collaborator

@cmontecoding cmontecoding commented Feb 21, 2025

Description

change zapping in and out to USDC > STATA instead of USDC > USDX

Checklist

  • Ran forge fmt?
  • Ran forge snapshot?
  • Ran forge test?

@JaredBorders
Copy link
Owner

@Flocqst @cmontecoding @moss-eth is this still needing review/merging

* 👷 add external functions for zapping USDX

* 👷 _zapOutUSDx
@cavalier-eth
Copy link

@JaredBorders @Flocqst the usdx and susd naming mix mentioend by auditors - is there a motivation?

Copy link
Owner

@JaredBorders JaredBorders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, things LGTM!

However, lets sync on these changes (and those downstream in SMv3) in the next 24 hours before merging.

But nj @Flocqst

Also, in the meantime, @moss-eth please review when you are able to.

@Flocqst Flocqst merged commit ec45182 into octopus Mar 26, 2025
2 checks passed
@Flocqst Flocqst deleted the stata-zap branch March 26, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants