Xlsx table import #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code directly imports from the user-visible table rather than from the nomadic tab. The rationale for this is that users have deleted cells and then references are lost or shifted in the data that are ingested by nomadic. This approach ensures that what the user sees is what the data will be in nomadic.
Default type for a barcode with direct ingestion will be a number ie. not prefixed with 'barcode'. Removed the default warning as if it is a number it is converted correctly and if not then will error out.
warnings.warn(f"Barcode '{barcode}' has bad format: must conform to '{EXAMPLE}'. Trying to fix...")