P1 Antonina #8
Open
P1 Antonina #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and checkForCommonWords)
…ce mode, edited common words in Alphabet, bruteforce works partially
…it Cypher.calculateKey() into 2 simpler methods; updated readme.md.
oleksandr-jr
approved these changes
Oct 19, 2024
Contributor
oleksandr-jr
left a comment
oleksandr-jr
left a comment
There was a problem hiding this comment.
This project is pure simplicity and elegance in good meaning.
- Good documented code.
- Cool solutions.
- Sometimes the architecture might be more open for future improvements.
Live review:
https://youtu.be/qgbS_6g_D-w?si=jVurwICoEBpScE3E&t=3953
Comment on lines
+16
to
+29
| for (int i = 0; i < text.length(); i++) { | ||
| char oneChar = text.charAt(i); // беремо символ з тексту | ||
| int index = Alphabet.ENGLISH_LOWERCASE.indexOf(oneChar); // шукаємо його в алфавіті lowercase | ||
| if (index != -1) { // якщо знайшли | ||
| result.append(rotatedLowercase.get(index)); // шифруємо і додаємо до результату | ||
| } else { // якщо немає | ||
| index = Alphabet.ENGLISH_UPPERCASE.indexOf(oneChar); // шукаємо його в алфавіті uppercase | ||
| if (index != -1) { // якщо знайшли | ||
| result.append(rotatedUppercase.get(index)); // шифруємо і додаємо до результату | ||
| } else { // якщо не знайшли в жодному з двох алфавітів, це спеціальний символ | ||
| result.append(text.charAt(i)); // НЕ шифруємо і просто додаємо | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This might be simplified.
Comment on lines
+9
to
+14
| public static final ArrayList<Character> ENGLISH_UPPERCASE = new ArrayList<>(Arrays.asList( | ||
| 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', | ||
| 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z')); | ||
| public static final ArrayList<Character> ENGLISH_LOWERCASE = new ArrayList<>(Arrays.asList( | ||
| 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', | ||
| 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z')); |
Contributor
There was a problem hiding this comment.
You could get rid of two lists and use only one by processing uppercase letters dynamically.
Comment on lines
+42
to
+51
| for (String line : text) { | ||
| encrypted = line; | ||
| for (int i = 0; i < 26; i++) { | ||
| decrypted = decrypt(line, i); | ||
| if (checkForCommonWords(decrypted)) { | ||
| break; | ||
| } | ||
| } | ||
| break; | ||
| } |
Contributor
There was a problem hiding this comment.
I like that you decrypt it using lines. In some cases, it's very effective, but there are also some cases when it might not work as expected. Maybe it's good idea to take more than 1 line if it contains not enough letters a.e. always use the text > 256 symbols.
Comment on lines
+24
to
+45
| linesRead = fileManager.read(runOptions.getFilePath()); | ||
| switch (runOptions.getCommand()) { | ||
| case ENCRYPT: | ||
| for (String lineRead : linesRead) { | ||
| linesWritten.add(cypher.encrypt(lineRead, runOptions.getKey())); | ||
| } | ||
| resultFile = fileManager.getNewPath(runOptions.getFilePath(), runOptions.getCommand()); | ||
| break; | ||
| case DECRYPT: | ||
| for (String lineRead : linesRead) { | ||
| linesWritten.add(cypher.decrypt(lineRead, runOptions.getKey())); | ||
| } | ||
| resultFile = fileManager.getNewPath(runOptions.getFilePath(), runOptions.getCommand()); | ||
| break; | ||
| case BRUTEFORCE: | ||
| int key = cypher.bruteForceKey(linesRead); | ||
| for (String lineRead : linesRead) { | ||
| linesWritten.add(cypher.decrypt(lineRead, key)); | ||
| } | ||
| resultFile = fileManager.getNewPath(runOptions.getFilePath(), key); | ||
| break; | ||
| } |
Contributor
There was a problem hiding this comment.
It's better to keep the logic out of the main method.
Contributor
There was a problem hiding this comment.
.jar file shouldn't be committed. It should be added as a release executable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project is done.