CesarCypher_ByDenysBurduzhan #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # readme.md
oleksandr-jr
approved these changes
Oct 19, 2024
Contributor
oleksandr-jr
left a comment
oleksandr-jr
left a comment
There was a problem hiding this comment.
Good implemented project with possible minor architectural improvements.
I hope you enjoyed the process and learned new things during this project.
Furthermore, I wish to see more of your projects in next modules. 🙂
| import java.io.IOException; | ||
| import java.nio.file.Path; | ||
|
|
||
| public class CryptAnalyzerGUI { |
Comment on lines
24
to
54
| try { | ||
| if (runOptions.getCommand() == Command.ENCRYPT) { | ||
| String content = fileManager.read(runOptions.getFilePath()); | ||
| String encryptedContent = cypher.encrypt(content, runOptions.getKey()); | ||
| String encryptedContent = cryptanalyzer.encryption(content, runOptions.getKey()); | ||
| String fileName = runOptions.getFilePath().getFileName().toString(); | ||
| String newFileName = fileName.substring(0, fileName.length() - 4) + " [ENCRYPTED].txt"; | ||
|
|
||
| Path newFilePath = runOptions.getFilePath().resolveSibling(newFileName); | ||
| fileManager.write(newFilePath, encryptedContent); | ||
| } else if (runOptions.getCommand() == Command.DECRYPT) { | ||
| String content = fileManager.read(runOptions.getFilePath()); | ||
| String encryptedContent = cryptanalyzer.decryption(content, runOptions.getKey()); | ||
| String fileName = runOptions.getFilePath().getFileName().toString(); | ||
| String newFileName = fileName.substring(0, fileName.length() - 4) + " [DECRYPTED].txt"; | ||
|
|
||
| Path newFilePath = runOptions.getFilePath().resolveSibling(newFileName); | ||
| fileManager.write(newFilePath, encryptedContent); | ||
| } else if (runOptions.getCommand() == Command.BRUTEFORCE) { | ||
| String content = fileManager.read(runOptions.getFilePath()); | ||
| String encryptedContent = runBruteforce.bruteforce(content,dictionary.getDictionary(), dictionary.getDictionaryUKR()); | ||
| String fileName = runOptions.getFilePath().getFileName().toString(); | ||
| String key = runBruteforce.getKey(content, dictionary.getDictionary(), dictionary.getDictionaryUKR()).replace("Key: ", ""); | ||
| String newFileName = fileName.substring(0, fileName.length() - 4) + " [DECRYPTED Key -" + key + "].txt"; | ||
|
|
||
| Path newFilePath = runOptions.getFilePath().resolveSibling(newFileName); | ||
| fileManager.write(newFilePath, encryptedContent); | ||
| } | ||
| } catch (Exception e) { | ||
| System.out.println(e.getMessage()); | ||
| }catch (Exception e){ | ||
| System.out.println("Smth went wrong"); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This code looks complicated and contains duplicates.
Could be simplified. See more here.
Comment on lines
+27
to
+63
| for (char symbol : array) { | ||
| if (Character.isLowerCase(symbol)) { | ||
| int originalIndex = constants.getEngLower().indexOf(symbol); | ||
| if (originalIndex != -1) { | ||
| Character encrypted = ENG_LOWER_MOD.get(originalIndex); | ||
| builder.append(encrypted); | ||
| continue; | ||
| } | ||
|
|
||
| originalIndex = constants.getUkrLower().indexOf(symbol); | ||
| if (originalIndex != -1) { | ||
| Character encrypted = UKR_LOWER_MOD.get(originalIndex); | ||
| builder.append(encrypted); | ||
| } else { | ||
| builder.append(symbol); | ||
| } | ||
| } | ||
| else if (Character.isUpperCase(symbol)) { | ||
| int originalIndex = constants.getEngUpper().indexOf(symbol); | ||
| if (originalIndex != -1) { | ||
| Character encrypted = ENG_UPPER_MOD.get(originalIndex); | ||
| builder.append(encrypted); | ||
| continue; | ||
| } | ||
|
|
||
| originalIndex = constants.getUkrUpper().indexOf(symbol); | ||
| if (originalIndex != -1) { | ||
| Character encrypted = UKR_UPPER_MOD.get(originalIndex); | ||
| builder.append(encrypted); | ||
| } else { | ||
| builder.append(symbol); | ||
| } | ||
| } else { | ||
| builder.append(symbol); | ||
| } | ||
| } | ||
| return builder.toString(); |
Contributor
There was a problem hiding this comment.
Too complicated and hard to read / change. Might be simplified by extracting methods. See more here.
| import ua.com.javarush.gnew.Constants.Constants; | ||
|
|
||
|
|
||
| public class RunBruteforce { |
Contributor
There was a problem hiding this comment.
Very good approach here. And my suggestion is the same here. It might be simplified by extracting methods and removing duplicates.
https://refactoring.guru/extract-method
https://refactoring.guru/uk/smells/duplicate-code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to review