-
Notifications
You must be signed in to change notification settings - Fork 1
Flyway is implemented #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
src/main/resources/application.yaml
Outdated
| api-secret: ${CLOUDINARY_API_SECRET} No newline at end of file | ||
| name: dru4hznjk | ||
| api-key: 374119777715921 | ||
| api-secret: 9OfudXe_H4kM7o5NmwdDRXW8yuQ No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, store security sensitive information in local starage, like your ide or consider using Cloud Config Service
|
|
||
| jpa: | ||
| hibernate: | ||
| ddl-auto: update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use ddl-auto: validate instead of ddl-auto: update to avoid accidental changes in DB, that won`t be tracked in Flyway
hrsweetlana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For next migration lets follow name convention for Flyway scripts, like V__.sql without using hyphenі in description section, only underline
|
I disabled the codacy analysis for .sql files |
now we have a common user with the role of admin,
login: test10
password: test10