Skip to content

Conversation

@JerrettDavis
Copy link
Owner

No description provided.

@github-actions
Copy link

Code Coverage

Summary
  Generated on: 11/18/2025 - 06:01:49
  Coverage date: 11/18/2025 - 06:01:20 - 11/18/2025 - 06:01:47
  Parser: MultiReport (7x Cobertura)
  Assemblies: 3
  Classes: 7
  Files: 6
  Line coverage: 39.6%
  Covered lines: 86
  Uncovered lines: 131
  Coverable lines: 217
  Total lines: 515
  Branch coverage: 29.2% (24 of 82)
  Covered branches: 24
  Total branches: 82
  Method coverage: 62.1% (23 of 37)
  Full method coverage: 54% (20 of 37)
  Covered methods: 23
  Fully covered methods: 20
  Total methods: 37

Slncs                      89.2%
  Slncs.Solution            100%
  Slncs.SolutionBuilder      89%

Slncs.Sdk                  30.5%
  Slncs.Sdk.SlncsExec         0%
  Slncs.Sdk.SlncsRunner      90%
  Slncs.Sdk.SlnxParse         0%

SlncsGen                      0%
  Program                     0%
  SlncsGen.ScriptGlobals      0%

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for .NET 10 to the project by updating target frameworks, SDK versions, package lock files, and CI/CD workflows.

Key changes:

  • Updated SDK version from 9.0.305 to 10.0.100 and Slncs.Sdk version from 0.1.22 to 10.0.100
  • Added net10.0 as a target framework alongside existing net8.0 and net9.0 targets
  • Updated Microsoft.Build package versions from 17.14.8 to 17.14.28
  • Modified GitHub Actions workflows to include .NET 10.0.x in the dotnet-version matrix
  • Regenerated package lock files to include net10.0 dependency trees

Critical Issue: As of January 2025, .NET 10 has not been officially released. The changes reference .NET 10 SDK version "10.0.100" and target framework "net10.0" which may not exist yet. This needs verification before the PR can be merged, as it will cause build and CI failures if these versions are not available.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
global.json Updated SDK version to 10.0.100 and Slncs.Sdk to 10.0.100
Directory.Build.props Added net10.0 to target frameworks for both test and non-test projects
Directory.Packages.props Updated Microsoft.Build.Framework and Microsoft.Build.Utilities.Core to version 17.14.28
.github/workflows/codeql-analysis.yml Added 10.0.x to dotnet-version matrix for CodeQL analysis
.github/workflows/ci.yml Added 10.0.x to dotnet-version matrix in both build and test jobs
tests/Slncs.Tests/packages.lock.json Added net10.0 dependency tree with updated package versions
tests/Slncs.Sdk.Tests/packages.lock.json Added net10.0 dependency tree and updated Microsoft.Build packages to 17.14.28
src/SlncsGen/packages.lock.json Added net10.0 dependency tree for SlncsGen project
src/Slncs/packages.lock.json Added empty net10.0 section (no dependencies)
src/Slncs.Tool/packages.lock.json Added net10.0 dependency tree and updated Microsoft.Build packages to 17.14.28
src/Slncs.Sdk/packages.lock.json Added net10.0 dependency tree with updated package versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@JerrettDavis JerrettDavis merged commit 80f9e51 into main Nov 20, 2025
10 checks passed
@JerrettDavis JerrettDavis deleted the feature/update-to-dotnet10 branch November 21, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants