Put code fence indents into separate whitespace nodes instead of fence content #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirstTimeInForever
force-pushed
the
master
branch
from
93debc8 to
48f26bc
Compare
FirstTimeInForever
force-pushed
the
master
branch
2 times, most recently
from
949c17e to
76cec19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, indented code fences are incorrectly represented in the AST. Currently, the actual indents are being put into the
CODE_FENCE_CONTENTnodes, which makes language injections much harder, since you need to manually calculate indents for each fence line.This PR solves this problem by calculating indents during parsing and putting them into separate
WHITE_SPACEnodes, so they won't pollute actual content nodes.