Skip to content

Don't resolve bookmark links of type #link to absolute URL #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kradima wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't resolve bookmark links of type #link to absolute URL #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ca8fcb
Don't resolve bookmark links of type `#link` to absolute URL but leav…
kradima Apr 11, 2018
d043436
Tests added - Don't resolve bookmark links of type `#link` to absolut…
kradima Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/org/intellij/markdown/html/GeneratingProviders.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ internal abstract class LinkGeneratingProvider(protected val baseURI: URI?) : Ge

protected fun makeAbsoluteUrl(destination : CharSequence) : CharSequence {
try {
if (destination.startsWith('#')) {
return destination
}
return baseURI?.resolve(destination.toString())?.toString() ?: destination
}
catch (e : IllegalArgumentException) {
Expand Down
2 changes: 2 additions & 0 deletions test/data/html/baseUriFile.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@
+ [parent directory relative link definition]
+ [absolute link definition]
+ [root link definition]
+ [bookmark link definition]


[implicit current directory relative link definition]: baz.html
[explicit current directory relative link definition]: ./baz.html
[parent directory relative link definition]: ../quux.html
[absolute link definition]: https://google.com/
[root link definition]: /root
[bookmark link definition]: #abc
3 changes: 3 additions & 0 deletions test/data/html/baseUriFile.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,8 @@
<li>
<a href="file:/root">root link definition</a>
</li>
<li>
<a href="#abc">bookmark link definition</a>
</li>
</ul>
</body>