rd-reflection: all null values for all reactive primitives and make c…

rd-net/RdFramework.Reflection/BindableChildrenUtil.cs

@@ -4,6 +4,7 @@
 using System.Reflection;
 using JetBrains.Diagnostics;
 using JetBrains.Rd.Base;
+using JetBrains.Rd.Tasks;
 using JetBrains.Rd.Util;
 using JetBrains.Util;
 
@@ -85,6 +86,13 @@ internal static void FillBindableFields(IReflectionBindable instance)
             // value can be null for fields primitive types in RdModels. They are used in serializations, but send their value on bind
             if (value != null)
               obj.BindableChildren.Add(new KeyValuePair<string, object>(bindableMembers[i].Name, value));
+
+            if (value is IRdReactive reactive)
+            {
+              reactive.ValueCanBeNull = true;
+              if (value is IRdCall)
+                reactive.Async = true;
+            }
           }
         };
         lock (ourFillBindableChildren)

rd-net/RdFramework.Reflection/ReflectionRdActivator.cs

@@ -334,20 +334,9 @@ public static void SetHandler<TReq, TRes>(RdCall<TReq, TRes> endpoint, Func<Life
         result = null;
       }
 
-      SetAsync(result);
-
       return result;
     }
 
-    private static void SetAsync(object? result)
-    {
-      if (result is IRdReactive activatedBindable)
-      {
-        //foreach (var _ in mi.GetCustomAttributes(typeof(RdAsyncAttribute), false))
-        activatedBindable.Async = true;
-      }
-    }
-
     private SerializerPair GetProperSerializer(Type type)
     {
       // registration for all statically known types

rd-net/RdFramework/Base/IRdReactive.cs

@@ -8,6 +8,7 @@ namespace JetBrains.Rd.Base
   public interface IRdReactive : IRdBindable, IRdWireable
   {
     bool Async { get; set; }
+    bool ValueCanBeNull { get; set; }
   }
 
 

rd-net/RdFramework/Impl/InternRoot.cs

@@ -191,6 +191,12 @@ public bool Async
       set => throw new NotSupportedException("Intern Roots are always async");
     }
 
+    public bool ValueCanBeNull
+    {
+      get => false;
+      set => throw new NotSupportedException("Intern Roots are always non-nullable");
+    }
+
     public void OnWireReceived(UnsafeReader reader, IRdWireableDispatchHelper dispatchHelper)
     {
       if (!TryGetSerializationContext(out var serializationCtx))

rd-net/RdFramework/Tasks/Interfaces.cs

@@ -20,7 +20,11 @@ public interface IRdEndpoint<TReq, TRes>
     void SetRdTask(Func<Lifetime, TReq, RdTask<TRes>> handler, IScheduler? cancellationScheduler = null, IScheduler? handlerScheduler = null);
   }
 
-  public interface IRdCall<in TReq, TRes>
+  public interface IRdCall
+  {
+  }
+
+  public interface IRdCall<in TReq, TRes> : IRdCall
   {
     TRes Sync(TReq request, RpcTimeouts? timeouts = null);
 

rd-net/RdFramework/Tasks/RdCall.cs

@@ -10,7 +10,7 @@
 
 namespace JetBrains.Rd.Tasks
 {
-  public class RdCall<TReq, TRes> : RdReactiveBase, IRdCall<TReq, TRes>, IRdEndpoint<TReq, TRes>
+  public class RdCall<TReq, TRes> : RdReactiveBase, IRdCall<TReq, TRes>, IRdEndpoint<TReq, TRes>, IRdCall
   {
     [PublicAPI]
     public CtxReadDelegate<TReq> ReadRequestDelegate { get; }