CT-3128 Fix for inputs inconsistent height on errors #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae24d9f.
RafalOzogJudopay
force-pushed
the
CT-3128-inputs-consistent-height-on-error
branch
from
c2a809e to
2114b1d
Compare
eugenezhernakov
approved these changes
Nov 26, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it doing: Solves problem of unequal inputs height on error. After research and playing around with flows and xml, I think that the most reliable solution is to take out horizontally-paired inputs out of the 'flows', and position them using simpler containers (LinearLayout).
It has been tested, and seems to work well both in CardEntry and BillingDetails screens.
Demo:
Before:
before.webm
After:
After.webm