Skip to content

Ignore whitespace during HTML parsing #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JustCabbage merged 1 commit into from
Aug 10, 2025
Merged

Ignore whitespace during HTML parsing #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ namespace HtmlParser

void Parser::InsertionModeBeforeHtml(const Token& Token)
{
if (Token.Type == TokenType::Character && isspace(Token.Data[0])) {
return; // Ignore whitespace
}
if (Token.Type == TokenType::StartTag && Utils::ToLower(Token.Data) == "html")
{
InsertElement(Token);
Expand All @@ -138,6 +141,9 @@ namespace HtmlParser

void Parser::InsertionModeBeforeHead(const Token& Token)
{
if (Token.Type == TokenType::Character && isspace(Token.Data[0])) {
return; // Ignore whitespace
}
if (Token.Type == TokenType::StartTag && Utils::ToLower(Token.Data) == "head")
{
InsertElement(Token);
Expand All @@ -157,6 +163,9 @@ namespace HtmlParser

void Parser::InsertionModeInHead(const Token& Token)
{
if (Token.Type == TokenType::Character && isspace(Token.Data[0])) {
return; // Ignore whitespace
}
if (Token.Type == TokenType::EndTag && Utils::ToLower(Token.Data) == "head")
{
OpenElements.pop_back();
Expand All @@ -173,6 +182,9 @@ namespace HtmlParser

void Parser::InsertionModeAfterHead(const Token& Token)
{
if (Token.Type == TokenType::Character && isspace(Token.Data[0])) {
return; // Ignore whitespace
}
if (Token.Type == TokenType::StartTag && Utils::ToLower(Token.Data) == "body")
{
InsertElement(Token);
Expand Down Expand Up @@ -209,4 +221,4 @@ namespace HtmlParser
// Handle other token types as needed
}
}
} // namespace HtmlParser
} // namespace HtmlParser
2 changes: 1 addition & 1 deletion tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
add_executable(RunTests ParserTest.cpp DOMTest.cpp DOMStrictTest.cpp QueryTest.cpp DOMToHtmlTest.cpp QueryAdvancedTest.cpp)
add_executable(RunTests ParserTest.cpp DOMTest.cpp DOMStrictTest.cpp QueryTest.cpp DOMToHtmlTest.cpp QueryAdvancedTest.cpp WhitespaceTest.cpp)
target_link_libraries(RunTests HtmlParser gtest gtest_main)

add_test(NAME ParserTest COMMAND RunTests)
36 changes: 36 additions & 0 deletions tests/WhitespaceTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
#include <gtest/gtest.h>
#include <HtmlParser/Parser.hpp>
#include <HtmlParser/DOM.hpp>

TEST(ParserWhitespaceTest, WhitespaceBeforeHtml)
{
HtmlParser::Parser Parser;
HtmlParser::DOM DOM = Parser.Parse(" \n\t <html><body></body></html>");
auto Body = DOM.GetElementsByTagName("body");
ASSERT_EQ(Body.size(), 1);
}

TEST(ParserWhitespaceTest, WhitespaceBeforeHead)
{
HtmlParser::Parser Parser;
HtmlParser::DOM DOM = Parser.Parse("<html> \n\t <head></head><body></body></html>");
auto Head = DOM.GetElementsByTagName("head");
ASSERT_EQ(Head.size(), 1);
}

TEST(ParserWhitespaceTest, WhitespaceInHead)
{
HtmlParser::Parser Parser;
HtmlParser::DOM DOM = Parser.Parse("<html><head> \n\t </head><body></body></html>");
auto Head = DOM.GetElementsByTagName("head");
ASSERT_EQ(Head.size(), 1);
}

TEST(ParserWhitespaceTest, WhitespaceAfterHead)
{
HtmlParser::Parser Parser;
HtmlParser::DOM DOM = Parser.Parse("<html><head></head> \n\t <body></body></html>");
auto Body = DOM.GetElementsByTagName("body");
ASSERT_EQ(Body.size(), 1);
}

Loading