make long_to_ts handle series of length 1 #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would crash when such series appeared in the data. Straight out stripping them might not always be the desired behavior. Another issue with the na.trim step here (in addition to the numeric imprecisions it introduces in the dates) is that it appears to round up the year of the (single observation) series.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would crash when such series appeared in the
data. Straight out stripping them might not always be the
desired behavior.
Another issue with the na.trim step here (in addition to the
numeric imprecisions it introduces in the dates) is that it
appears to round up the year of the (single observation) series.