Skip to content

Fix browser opening for URLs with query parameters #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kamyil merged 1 commit into from
Nov 27, 2025
Merged

Fix browser opening for URLs with query parameters #44

Kamyil merged 1 commit into from
Nov 27, 2025

Conversation

@Kamyil
Copy link
Owner

@Kamyil Kamyil commented Nov 27, 2025 •
edited
Loading

Summary

  • Fixes issue T/L open bowser Not work with params #42 where T/L browser opening didn't work with URLs containing query parameters
  • On Windows, the & character in URLs was being interpreted as a command separator by cmd.exe
  • Refactored browser opening code into a dedicated helper function

Changes

  • Extract open_url_in_browser() helper function for cleaner, DRY code
  • Fix Windows implementation: use start "" url instead of start url to properly handle URLs with & characters
  • Add test cases for Zentao-style URLs with query parameters

Fix browser opening for URLs with query parameters on Windows
852dbef 
- Extract open_url_in_browser() helper function for cleaner code
- Fix Windows: use 'start "" url' to prevent & being interpreted as command separator
- Add tests for URLs with query parameters (issue #42 Zentao-style URLs)

Closes #42
@Kamyil Kamyil force-pushed the fix/issue-42-url-query-params branch from c651dd2 to 852dbef Compare November 27, 2025 14:23
@Kamyil Kamyil merged commit 117dd10 into main Nov 27, 2025
3 checks passed
@Kamyil Kamyil mentioned this pull request Dec 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kamyil