Skip to content

Simple solution to mutability problem, to solve error on PR #3 and PR #5 addressing issue #2 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KarlHeitmann wants to merge 1 commit into
base: refactor_explorer
Choose a base branch
from
Draft

Simple solution to mutability problem, to solve error on PR #3 and PR #5 addressing issue #2 #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/explorer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,11 @@ impl<'a> GitExplorer {
branches.push(BranchData::from(b));
}
// let branches = branches.map(|b| BranchData::new(b)).collect();
self.paint_commit_track(self.repo.head().unwrap().peel_to_commit().unwrap(), branches)
let commit;
{
commit = self.repo.head().unwrap().peel_to_commit().unwrap();
}
self.paint_commit_track(commit, branches)
}
};
self.nodes_len = nodes.len();
Expand Down Expand Up @@ -204,7 +208,7 @@ impl<'a> GitExplorer {
}

fn paint_branch(
&self,
&mut self,
mut commits: Vec<Commit>,
mut output: Vec<GraphNode>,
limit_stack: Option<usize>,
Expand Down Expand Up @@ -318,7 +322,7 @@ impl<'a> GitExplorer {
[output, vec_str].concat()
}

pub fn paint_commit_track(&self, commit: Commit, branches: Vec<BranchData>) -> Vec<GraphNode> {
pub fn paint_commit_track(&mut self, commit: Commit, branches: Vec<BranchData>) -> Vec<GraphNode> {
// let limit_stack = 1000; // Works fine
let limit_stack = 500; // Works fine
// let limit_stack = 10000; // Works, but it is unhandeable :/
Expand Down