Skip to content

Conversation

@Katze719
Copy link
Owner

  • Introduced an ABI marker in the RegisteredThreadInfo struct to intentionally change its layout, indicating a major version bump.

- Introduced an ABI marker in the RegisteredThreadInfo struct to intentionally change its layout, indicating a major version bump.
- Removed old ThreadSchedule configuration and updated include directories to use headers from the previously installed ThreadSchedule.
- Added a compile definition for runtime declarations and adjusted linking for Windows and ELF platforms to ensure compatibility with the current runtime.
- Enhanced dependency management for the runtime library.
@Katze719 Katze719 force-pushed the test-abi-check-test branch 2 times, most recently from 6432b94 to cd3239b Compare October 21, 2025 19:53
@Katze719 Katze719 requested a review from Copilot October 23, 2025 19:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an ABI marker to the RegisteredThreadInfo structure to intentionally change its memory layout, signaling a major version bump in the library's binary interface. The changes also include build system updates to handle runtime ABI compatibility testing with old and new versions of the ThreadSchedule library.

Key changes:

  • Build configuration updated to use headers from old ThreadSchedule installation while linking against current runtime
  • Code formatting improvement in thread affinity logic (return statement restructured)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
integration_tests/runtime_abi_compat/libB/CMakeLists.txt Refactored build configuration to separate header inclusion from linking, enabling ABI compatibility testing between versions
include/threadschedule/thread_wrapper.hpp Reformatted conditional return statement for better readability

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Katze719 Katze719 merged commit 88f16cf into main Oct 23, 2025
43 checks passed
@Katze719 Katze719 deleted the test-abi-check-test branch October 23, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants