Skip to content

Conversation

@samysweb
Copy link
Contributor

@samysweb samysweb commented Mar 9, 2023

See (future) comment in #3023 that will mention this pull request in a few minutes

@wadoon
Copy link
Member

wadoon commented Mar 10, 2023

@mattulbrich Has someone changed the branch protection settings? Github tells me I am able to merge this PR without an reviewer approval.

@samysweb
Copy link
Contributor Author

@wadoon I believe this is probably the case because I only asked to merge this into KeYProject:mu/unbalancedFloats (and not into the protected main branch)

@wadoon wadoon requested a review from mattulbrich March 11, 2023 08:20
@jwiesler
Copy link
Contributor

@wadoon tests aren't run either for this one.

@jwiesler
Copy link
Contributor

And I thought this repo shouldn't be used for user branches (mu/unbalancedFloats, weigl/java17)

@mattulbrich
Copy link
Member

@mattulbrich Has someone changed the branch protection settings? Github tells me I am able to merge this PR without an reviewer approval.

I have added you to the group of developers.

@samysweb
Copy link
Contributor Author

samysweb commented Apr 5, 2023

@mattulbrich: If you're OK with that I will merge these changes into your unbalancedFloats branch.
This will run the entire test suite on this and tell us:

  • If the additional varcond break any proofs (at least on my machine this didn't seem to be the case)
  • Whether the changes significantly slow down the proofs due to the additional condition checks

@mattulbrich
Copy link
Member

Yes, please go ahead!

@samysweb samysweb merged commit 02be342 into KeYProject:mu/unbalancedFloats Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants