Skip to content

Conversation

@wadoon
Copy link
Member

@wadoon wadoon commented May 5, 2025

Currently, if SMT solvers are not available during testing, these test cases will be silently ignored---a behavior acceptable on local machines, but not on CI.

On CI, this is firstly ensured by executing z3 and cvc5 on command-line. This ensures installation, but not that KeY finds the executable.

This PR changes the behavior of SMT test cases to failing if SMT solvers are not present, and an additional flag is set.

This flag is set iff the environment variables sets failIfSmtSolverIsUnavailable or GITHUB_ACTIONS to true.

Type of pull request

  • New feature (non-breaking change which adds functionality)
  • There are changes to the (Java) code

Ensuring quality

  • I added new test case(s) for new functionality.
  • I have tested the feature as follows: CI

@wadoon wadoon self-assigned this May 5, 2025
@wadoon wadoon requested a review from Drodt May 6, 2025 09:03
@wadoon wadoon marked this pull request as ready for review May 6, 2025 09:04
@wadoon
Copy link
Member Author

wadoon commented May 6, 2025

Fails as cvc4 is not available on Github Actions. @WolframPfeifer

@wadoon
Copy link
Member Author

wadoon commented May 9, 2025

Migration to cvc5 as far as possible.

@mattulbrich
Copy link
Member

Agreed at meeting: Retire CVC4 support. Migrate test cases to CVC5 is possible, drop otherwise.
@WolframPfeifer can migrate test cases from other PR #3592. Then merge that onto master, that might resolve issues here.

@wadoon
Copy link
Member Author

wadoon commented May 9, 2025

wait for #3592

@WolframPfeifer WolframPfeifer mentioned this pull request May 9, 2025
4 tasks
@WolframPfeifer
Copy link
Member

#3592 is merged into main, I updated this PR. Also, I migrated the CVC4 test case to cvc5, so this PR should be merge-ready now.

@WolframPfeifer WolframPfeifer added the Review Request Waiting for review label May 9, 2025
@wadoon wadoon enabled auto-merge May 11, 2025 01:17
@WolframPfeifer
Copy link
Member

We need an additional reviewer, since @wadoon and I both have committed to this PR ...
Can somebody else please review? It contains only small changes and should be very easy to review.

@wadoon wadoon added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit a085d8e May 15, 2025
7 checks passed
@wadoon wadoon deleted the weigl/smtcheckci branch May 15, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants