module-info.java, 2nd attempt #3623
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadoon
force-pushed
the
weigl/module
branch
2 times, most recently
from
ef482fd to
a10effd
Compare
locally not reproducible
error in docking frames version, cannot find resource bundle
Member
|
Is this really ready for review? |
Member
Author
A review should wait for #3621. This PR builds upon it (removal of ST4). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second run for module-info in KeY after the drop of ST4. Builds-upon #3621, should merged afterwards.
This pull request adds module support in KeY by adding
module-info.javaand doing the necessary stuff. There are three main issues with modules in KeY:clashing Java packages (packages are sealed)
(solved by renaming some packages)
Docking Frames is not-modularized
(Baked a new version, with renamed packages. **This version is on central snapshot repo, and should then be deployed to Maven central)
Caching extension in wrong service file
Additional:
Hint:
Type of pull request