OpenCOLLADA/CMakeLists.txt: : Build type, GNUInstallDirs, and version fixes #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes Use CMAKE_BUILD_TYPE which can be overrided with custom distro types Adhere to GNU filesystem layout conventions. Not all distros and OSes have directories in the same locations and they define the GNUInstallDirs variables, so use those variables. Also, this enables multi lib installations. Define the version variables to enable SONAME versioning on the library files in case there is ABI changes in the future.
|
SUCCESS: exercise-opencollada-pull-request build #141
Pull Requests:
|
|
Hi. any update of this? greetings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CMAKE_BUILD_TYPE which can be overrided with custom distro types
Adhere to GNU filesystem layout conventions. Not all distros and OSes
have directories in the same locations and they define the
GNUInstallDirs variables, so use those variables. Also, this enables
multi lib installations.
Define the version variables to enable SONAME versioning on the
library files in case there is ABI changes in the future.
Please note: I set SONAME to be major.minor as I don't know what ABI version you are on. If it's been the same since the beginning, then it can just be set to 1, or if there was a only one change, then 2 and so on. I don't know if there even were ABI changes. However, it would be nice to have at lease a SONAME of 1 just in case there are future ABI changes.
Let me know if you want change how the variables are handled, so I can push updates to this patch.