Build: update cmake minimum version to 3.10 #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cmake ABI compatibility with cmake <3.5 has been removed in cmake 4. Compatibility with cmake <3.10 is deprecated and soon to be removed. Thus set 3.10 minimum version. This is available in the vast majority of current linux distributions, as well as other platforms.
LordGrimmauld
force-pushed
the
cmake-4-compat
branch
from
3031354 to
f036950
Compare
LordGrimmauld
changed the title
|
Would be great if repo could adapt some simple patches like these, so we could at least point to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake ABI compatibility with cmake <3.5 has been removed in cmake 4. Compatibility with cmake <3.10 is deprecated and soon to be removed. Thus set 3.10 minimum version. This is available in the vast majority of current linux distributions, as well as other platforms.
This project looks somewhat dead, i do not expect a merge. But i might as well post the patch here.
Gentoo already did a similar patch, see https://gitweb.gentoo.org/repo/gentoo.git/plain/media-libs/opencollada/files/opencollada-1.6.68-cmake4.patch?id=42f1e0614c4d056841fdc162c29a04ff0e910139. They did however not upstream their work.