Bugfix in get_viscosity_kinematic #281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A recent change to
get_salt_dict(see #258 ) created a problem withget_viscosity_kinetmaticthat was not previously being tested. Before #258 ,get_salt()would always return a salt object, even for pure water (in which case the anion and cation were OH- and H+. After the PR,get_saltreturnsNone. This PR handles this possibility and adds tests to ensureget_viscosity_kinematicworks correctly even for pure water.