Skip to content

Conversation

@vineetbansal
Copy link
Collaborator

Summary

Added a new nested argument to two methods in the Solution class, as per our discussions wrt issue #229
Old behavior is unchanged. At some future point we might consider only having nested=True supported (and subsequently remove the argument altogether).

Checklist

  • Google format doc strings added.
  • Code linted with ruff. (For guidance in fixing rule violates, see rule list)
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • I have run the tests locally and they passed.

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

@rkingsbury
Copy link
Member

Looks great @vineetbansal; thanks for adding the type hints in!

Can you please update the CHANGELOG as well? I'm just going to make sure tests pass on our CI and then I'll merge.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.78%. Comparing base (256bc5d) to head (59523f4).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   84.72%   84.78%   +0.06%     
==========================================
  Files           9        9              
  Lines        1460     1466       +6     
  Branches      251      255       +4     
==========================================
+ Hits         1237     1243       +6     
  Misses        193      193              
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vineetbansal
Copy link
Collaborator Author

Thanks @rkingsbury - I've updated the changelog (added bullet point under the "unreleased" heading).

@rkingsbury rkingsbury merged commit c6c3c17 into KingsburyLab:main Oct 13, 2025
16 of 17 checks passed
@rkingsbury
Copy link
Member

Thanks @vineetbansal , merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants