Diffusion Coefficient from Phreeqc #316
Open
+145
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduced a
get_diffusion_coefficientmethod in thePHRQSolclass.Since pyEQL's
Solutionclass was calculating this property itself (regardless of its engine), the way I'm gradually introducing this is to use an optionaluse_engineparameter in the following methods in theSolutionclass:get_diffusion_coefficient/_get_diffusion_coefficient- This delegates to the new wrapper ifTrue, with minimal handling of edge cases in theSolutionclass itself (default value etc)._get_molar_conductivity- callsget_diffusion_coefficientwith the sameuse_engineit got called with.get_transport_number- calls_get_molar_conductivitywith the sameuse_engineit got called with.Behavior is unchanged of
use_engineisFalse(the default).If there's an alternate way to start adding this functionality, I'm happy to refactor.
I've introduced a new test module
test_solution_pyeql_engine.pyin parallel withtest_solution.py, with the former building up to the latter as we add more functionality to the new wrapper and expose them through theSolutionclass.The relevant diff between the two cases that we may want to discuss is below. Looks like with phreeqc, diffusion coefficient of
H+is unaffected by presence ofNaCl, and significantly increasing concentration ofNaCl(orKCl) has no affect on diffusion coefficient for their ions either.Checklist
ruff. (For guidance in fixing rule violates, see rule list)mypy.