Skip to content

Conversation

@big-nacho
Copy link
Collaborator

Description:

Changes how the boolean operations are performed. Instead of subtracting the next path from the current, we use a different approach that always subtracts from a rectangle covering the image + some padding. This helps reduce the amount of overlapping edges between the two paths involved in the boolean operation, which seems to be a big contributing factor to the creation of holes.

With this change I haven't seen holes created, but it does fail sometimes (same as before, maybe a bit more). In that case, we accept however many paths we could make disjoint and the rest are left untouched. In many cases (photographs, clip art with lots of raster content) results will be partially layered. But that should be outweighed by the fact that for most clip art illustrations, simpler, separate paths should be created.

  • I have self-reviewed this PR, according to these points
  • This PR falls into maximum three of these categories
  • I feel comfortable taking responsibility for merging this code to production
  • The code is high quality, well-tested, follows styles guides (Frontend), clean, and well documented

@big-nacho big-nacho marked this pull request as draft June 4, 2025 15:29
@big-nacho big-nacho marked this pull request as ready for review June 4, 2025 16:00
@big-nacho big-nacho merged commit 91032f2 into main Jun 10, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants