Skip to content

Conversation

@naglepuff
Copy link
Collaborator

@naglepuff naglepuff commented Nov 12, 2025

Fix #259

Adds the ability to add a tag to recordings on upload or update. Displays the tag in the recordings table, and allows for filtering by one or more tags.

Here is what model management looks like for tags:
image

Each recording tag has a text value and belongs to a specific user. When that user is logged in, they can choose from pre-existing tags that they've created, or type in a new tag:
image

Each table also has a drop-down on top to enable filtering by tag. The tag column is sortable.
image

Todo:

  • Select tag for bulk upload

@naglepuff naglepuff marked this pull request as ready for review November 13, 2025 18:25
@naglepuff naglepuff requested a review from BryonLewis November 13, 2025 18:25
Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This completely works functionally given the requirements of issue. The only 'real' requested change is some minor typing stuff in the client.
I have some questions about the functionality that may require some group discussion. Mostly these are questions that if they change the requirements I think would be better addressed in this PR instead of trying to do migration in the future (mostly the idea of multiple tags being associated with a recoring and if we want to support that). I just bring up the multiple tags because my experience indicates that someone is going to ask for it down the line.

@naglepuff naglepuff force-pushed the issue-259-tag-uploads branch from 0c60f19 to 156e19d Compare November 17, 2025 22:02
@naglepuff naglepuff force-pushed the issue-259-tag-uploads branch 2 times, most recently from 3756ebe to 304c900 Compare November 25, 2025 20:39
@naglepuff naglepuff force-pushed the issue-259-tag-uploads branch from 304c900 to f315b0c Compare November 25, 2025 21:02
@naglepuff naglepuff requested a review from BryonLewis November 25, 2025 21:21
@naglepuff
Copy link
Collaborator Author

Change Tag -> Tags in the UI

Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the multi tag stuff
Just a few minor things:

The patch request on Recording and modification so it accepts multiple new tags and allows for removal of tags

See if the number of migration files can be reduced by recreating the migrations

The idea of uniqueness and tags being tied to a user can be visited in the future. Don't do anything but just think about it a bit.

@naglepuff naglepuff force-pushed the issue-259-tag-uploads branch from 3d70e41 to 2a36084 Compare December 1, 2025 20:34
Co-authored-by: Bryon Lewis
<61746913+BryonLewis@users.noreply.github.com>
@naglepuff naglepuff force-pushed the issue-259-tag-uploads branch from 2a36084 to 8159e92 Compare December 1, 2025 20:37
@naglepuff naglepuff requested a review from BryonLewis December 1, 2025 20:45
Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@naglepuff naglepuff merged commit 508b305 into main Dec 2, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow users to tag files on upload for filtering

2 participants