Bulk Import Management Command #271
Conversation
naglepuff
left a comment
naglepuff
left a comment
There was a problem hiding this comment.
This looks good and works great in docker. Natively it doesn't seem to work (perhaps due to the version of python being used to run it?) without the suggestion regarding matplotlib. I'm fine if this gets merged as-is. Comments here are generally just minor suggestions.
bats_ai/core/utils/guano_utils.py
Outdated
| label_name = match.group(2) | ||
| date_str = match.group(3) | ||
| timestamp_str = match.group(4) | ||
| # extra_data = match.group(5) # Not used currently |
There was a problem hiding this comment.
Are there plans to use this in the future? Should we track this with an issue instead of a comment? I can imagine a scenario where this line becomes confusing or raises questions for new developers or us in the future.
There was a problem hiding this comment.
I'll remove it, it's not data that is needed.
| except Exception as e: | ||
| self.stdout.write( | ||
| self.style.ERROR(f' Failed to generate spectrogram: {str(e)}') | ||
| ) | ||
| logger.exception('Error generating spectrogram', exc_info=e) |
There was a problem hiding this comment.
Does this need to re-raise so the outer try/except can properly increment failed?
There was a problem hiding this comment.
I'll update to add it in.
Co-authored-by: Michael Nagler <mike.nagler@kitware.com>
Co-authored-by: Michael Nagler <mike.nagler@kitware.com>
Co-authored-by: Michael Nagler <mike.nagler@kitware.com>
2 participants
Creates a new management command that allows for bulk importing WAV files.