Widgetize pan3d #207
Merged
Widgetize pan3d #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
reviewed
Aug 12, 2025
jourdain
reviewed
Aug 12, 2025
jourdain
reviewed
Aug 12, 2025
jourdain
reviewed
Aug 12, 2025
jourdain
reviewed
Aug 12, 2025
jourdain
reviewed
Aug 12, 2025
jourdain
reviewed
Aug 12, 2025
jourdain
reviewed
Aug 12, 2025
ayenpure
force-pushed
the
widgetize_pan3d
branch
2 times, most recently
from
60665af to
f55e1b3
Compare
Collaborator
Author
|
Provides a fix to #199 |
ayenpure
force-pushed
the
widgetize_pan3d
branch
2 times, most recently
from
bd42218 to
7bd98bc
Compare
Collaborator
Author
|
@jourdain ready for tound 2 -- I'll work on fixing the failing test too. |
Collaborator
|
osmesa failing can be fixed with Kitware/trame-vtklocal@0545876 |
jourdain
reviewed
Aug 13, 2025
jourdain
reviewed
Aug 13, 2025
jourdain
reviewed
Aug 13, 2025
ayenpure
force-pushed
the
widgetize_pan3d
branch
from
7bd98bc to
7683c4b
Compare
- Create 12 new widget modules (pan3d_view, data_origin, data_information, etc.) - Move common UI patterns from explorers to centralized widgets - Introduce StandardExplorerLayout for consistent UI structure - Improve maintainability with single source of truth for UI components
- Merge separate X/Y/Z controls into single widget instance - Update preview and globe modules to use new widget API
- Create new VectorPropertyControl widget for handling X/Y/Z properties - Replace separate LevelOfDetail and ScaleControl widgets - Support scale, step, and other vector properties through single interface
- Extract ControlPanel to pan3d.ui.control_panel module - Extract RenderingSettingsBasic to pan3d.ui.rendering_settings module - Create SummaryToolbar widget from common.py code - Remove duplicate imports and unused properties
ayenpure
force-pushed
the
widgetize_pan3d
branch
from
7683c4b to
43e463d
Compare
jourdain
reviewed
Aug 19, 2025
jourdain
approved these changes
Aug 19, 2025
Collaborator
jourdain
left a comment
jourdain
left a comment
There was a problem hiding this comment.
We should remove the TrameApp annotation. This could happen in another PR if need be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.