-
Notifications
You must be signed in to change notification settings - Fork 2
Files edited #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Files edited #5
Conversation
SebaDro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I have a few suggestions to make the dev-proxy and prod setup working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be left empty because it will be filled at initial startup
| upstream geocoder-proxy { | ||
| server ${GEOCODER_PROXY}; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to add these lines also to the default.conf.template in the dev-proxy folder. However, nginx won't recognize the geocoder-proxy service, becaus it is not available in the same network. So, you should add the kommonitor network to the docker-compose file for the geocoder in dev-proxy and prod setup.
| location /kommonitor/api/geocoderproxy/ { | ||
| proxy_pass http://geocoder-proxy/; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: add these lines to the default.conf.template in the dev-proxy folder.
| url: http://swagger.io | ||
| servers: | ||
| #- url: https://geocoder.fbg-hsbo.de/ | ||
| - url: http://localhost:8092/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL should be slightly different in the dev-proxy and prod setup. I'd suggest to move this file to the common config directory and add the URLs for the dev-proxy and prod setup here. This avoids having nearly the same file in each setup.
No description provided.