Skip to content

Conversation

@Ludovic2035
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@SebaDro SebaDro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I have a few suggestions to make the dev-proxy and prod setup working.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be left empty because it will be filled at initial startup

Comment on lines +19 to +21
upstream geocoder-proxy {
server ${GEOCODER_PROXY};
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to add these lines also to the default.conf.template in the dev-proxy folder. However, nginx won't recognize the geocoder-proxy service, becaus it is not available in the same network. So, you should add the kommonitor network to the docker-compose file for the geocoder in dev-proxy and prod setup.

Comment on lines +54 to +56
location /kommonitor/api/geocoderproxy/ {
proxy_pass http://geocoder-proxy/;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: add these lines to the default.conf.template in the dev-proxy folder.

url: http://swagger.io
servers:
#- url: https://geocoder.fbg-hsbo.de/
- url: http://localhost:8092/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL should be slightly different in the dev-proxy and prod setup. I'd suggest to move this file to the common config directory and add the URLs for the dev-proxy and prod setup here. This avoids having nearly the same file in each setup.

@SebaDro SebaDro self-requested a review August 20, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants