-
-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor extension packaging workflow to use root directory #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
KubrickCode
commented
Sep 30, 2025
- Add *.vsix pattern to gitignore for packaged extensions
- Update justfile publish command to auto-detect latest .vsix file
- Simplify package scripts by removing versions/ directory output
- Add cleanup logic to remove old .vsix files after publishing
- Remove obsolete versioned .vsix files from versions/ directory
|
/gemini review |
Summary of ChangesHello @KubrickCode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the extension packaging and publishing workflow to be more efficient and maintainable. It centralizes '.vsix' file generation to the project root, automates the selection of the correct file for publishing, and includes cleanup steps to manage generated artifacts. These changes simplify the build process and ensure a cleaner repository state. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
d91c38e to
7c7ae88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the extension packaging and publishing workflow, simplifying the process by packaging to the root directory and updating the justfile to automatically handle the latest .vsix file. My feedback focuses on improving the robustness of the publishing scripts by ensuring project-local dependencies are used, and on centralizing the publishing logic to improve maintainability.
- Add *.vsix pattern to gitignore for packaged extensions - Update justfile publish command to auto-detect latest .vsix file - Simplify package scripts by removing versions/ directory output - Add cleanup logic to remove old .vsix files after publishing - Remove obsolete versioned .vsix files from versions/ directory issue #39
7c7ae88 to
eea6b18
Compare