Skip to content

Conversation

@mhovd
Copy link
Collaborator

@mhovd mhovd commented Jan 14, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 14, 2026 09:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames and reorganizes the data parsing infrastructure to better reflect its generic, format-agnostic nature. The changes move from Pmetrics-specific naming to more general terminology.

Changes:

  • Renamed NormalizedRow to DataRow and NormalizedRowBuilder to DataRowBuilder to better reflect their format-agnostic purpose
  • Renamed PmetricsError to DataError and moved it from parser/pmetrics.rs to row.rs to reflect its broader scope
  • Moved the row module from data/parser/normalized.rs to data/row.rs as a standalone module
  • Updated all imports, exports, and references throughout the codebase to use the new naming

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/lib.rs Updated prelude exports to use DataRow and DataRowBuilder instead of NormalizedRow and NormalizedRowBuilder
src/error/mod.rs Changed error variant from PmetricsError to DataError and updated import path to crate::data::row::DataError
src/data/row.rs Renamed NormalizedRow to DataRow, NormalizedRowBuilder to DataRowBuilder, and moved DataError from pmetrics module; updated all documentation and test references
src/data/parser/pmetrics.rs Removed PmetricsError definition (moved to row.rs), updated imports to use DataError and DataRow, renamed to_normalized() to to_datarow()
src/data/parser/mod.rs Removed normalized module, updated re-exports to use crate::data::row for DataRow, DataRowBuilder, and build_data
src/data/mod.rs Added row module declaration
Comments suppressed due to low confidence (1)

src/data/row.rs:563

  • There's a grammatical error in the error message. "Observation OUTEQ is missing in for" should be "Observation OUTEQ is missing for" (remove "in").

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mhovd and others added 3 commits January 14, 2026 10:27
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants