Skip to content

Conversation

@acsenrafilho
Copy link
Member

@acsenrafilho acsenrafilho commented Sep 10, 2025

Pull Request Template

Description

  • Quick fix to multi-TE ASL recosntruction bug when a 4D m0 is passed to the object.
  • Fixed both the MultiTEASLMapping class and te_asl.py script

Type of Change

Please select the relevant option(s):

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation update (changes to documentation)
  • 🎨 Code style/formatting (non-functional changes)
  • ♻️ Code refactoring (no functional changes, no api changes)
  • ⚡ Performance improvements
  • 🧪 Test additions or improvements
  • 🔧 Build/CI configuration changes

Related Issues

Code Quality Checklist

Testing Requirements ✅

  • All existing tests pass
  • New functionality includes appropriate unit tests
  • Code follows the project's coding standards
  • Code passes linting checks (task lint-check)
  • Code includes appropriate inline documentation

Note: According to our contribution guidelines, please target the develop branch for most contributions to ensure proper testing before merging to main.

By submitting this pull request, I confirm:

  • I have read and followed the contribution guidelines
  • I have tested my changes thoroughly
  • I understand this is an open source project and my contributions may be used by others
  • I agree to the project's Code of Conduct

@acsenrafilho acsenrafilho added the bug Something isn't working label Sep 10, 2025
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
asltk/asldata.py 97.52% <100.00%> (+0.04%) ⬆️
asltk/reconstruction/cbf_mapping.py 95.69% <100.00%> (+0.04%) ⬆️
asltk/reconstruction/multi_te_mapping.py 99.03% <100.00%> (+<0.01%) ⬆️
asltk/reconstruction/t2_mapping.py 92.30% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acsenrafilho acsenrafilho merged commit fffe4e9 into main Sep 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants